This repository has been archived by the owner on Mar 31, 2022. It is now read-only.
support for loading Google credentials from environment file #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidxia
approved these changes
Jun 5, 2017
mattnworb
force-pushed
the
mattbrown/gcr-environment-variable
branch
from
b5efd7c to
9901515
Compare
|
👍 |
Build the DockerClient instance so that it always uses the new ConfigFileRegistryAuthSupplier (from docker-client 8.6.3) to support any auth info in the docker config file. In the cases where Google credentials are available, use those with higher precedence than the config file.
Adds support for loading Google credentials from the environment variable DOCKER_GOOGLE_CREDENTIALS if it is set and points to a readable file. If not set, then the Google Application Default Credentials are still used as before.
mattnworb
force-pushed
the
mattbrown/gcr-environment-variable
branch
from
0449624 to
67548e1
Compare
davidxia
approved these changes
Jun 5, 2017
mattnworb
force-pushed
the
mattbrown/gcr-environment-variable
branch
5 times, most recently
from
7932b55 to
7e91058
Compare
davidxia
force-pushed
the
mattbrown/gcr-environment-variable
branch
from
7e91058 to
e901d0e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for loading Google credentials from the environment variable DOCKER_GOOGLE_CREDENTIALS if it is set and points to a readable file.
If not set, then the Google Application Default Credentials are still used as before (if they can be loaded).
This PR also includes a change to use authentication info from the docker-cli config file, which in turn depends on some not-yet-released changes in docker-client (see spotify/docker-client#775). This will resolve a number of open issues in this repository around a lack of authentication support.
The build will fail until spotify/docker-client#775 is complete and released, but I wanted to create the PR now to start the review process.
In the cases where Google credentials are available, use those with higher precedence than the config file.